[fix] Enforce the QueryResult.df to be a pandas.DataFrame (Phase II) #8948
+9
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CATEGORY
Choose one
SUMMARY
Related to #8935 this PR cleans up other places in the code where the
df
variable was eitherNone
or apandas.DataFrame
object. Given that now bothQueryResult
andpydruid
guarantee exporting of apandas.DataFrame
(which could be empty) the downstream logic is now simplified.TEST PLAN
CI.
ADDITIONAL INFORMATION
REVIEWERS
to: @mistercrunch @michellethomas @villebro @willbarrett